[ofa-general] Re: [PATCH 1/10 REV5] [Doc] HOWTO Documentation for batching
Krishna Kumar2
krkumar2 at in.ibm.com
Sun Sep 16 21:10:36 PDT 2007
Hi Randy,
Randy Dunlap <randy.dunlap at oracle.com> wrote on 09/15/2007 12:07:09 AM:
> > + To fix this problem, error cases where driver xmit gets called with
a
> > + skb must code as follows:
> > + 1. If driver xmit cannot get tx lock, return NETDEV_TX_LOCKED
> > + as usual. This allows qdisc to requeue the skb.
> > + 2. If driver xmit got the lock but failed to send the skb, it
> > + should return NETDEV_TX_BUSY but before that it should have
> > + queue'd the skb to the batch list. In this case, the qdisc
>
> queued
>
> > + does not requeue the skb.
Since this was a new section that I added to the documentation, this error
creeped up. Thanks for catching it, and review comments/ack-off :)
thanks,
- KK
More information about the general
mailing list