[ofa-general] Re: [PATCH 02/11] IB/ipoib: Notify the world before doing unregister

[Jay Vosburgh]

Roland Dreier <rdreier at cisco.com> wrote:

>Actually, thinking about this some more... would it be cleaner to more
>the knowledge about bonding out of the ipoib driver?  in other words,
>export something similar to
>
> > +static int ipoib_slave_detach(struct net_device *dev)
> > +{
> > +	int ret = 0;
> > +	if (dev->flags & IFF_SLAVE) {
> > +		dev->priv_flags |= IFF_SLAVE_DETACH;
> > +		rtnl_lock();
> > +		ret = call_netdevice_notifiers(NETDEV_CHANGE, dev);
> > +		rtnl_unlock();
> > +	}
> > +	return ret;
> > +}
>
>for drivers to use, rather than putting use of IFF_SLAVE and
>IFF_SLAVE_DETACH outside of the bonding driver.

	Conceptually, I see your point and I'm ok with doing it either
way.  My only question is, would this change would make the ipoib module
dependent upon having the bonding module loaded (to resolve all of the
symbols)?

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar at us.ibm.com