[ofa-general] Re: [PATCH v8] IB/mlx4: shrinking WQE

[Michael S. Tsirkin]

> It turns out I just resent the old patch version instead of
> posting a new one. Sorry about that, here's one that actually
> implements the changes:
> 
> Changes since v7:
> - avoid mis-detecting recv write with immediate completion as NOP
> - increase min. wqe_shift for RC QPs to 64 bytes, so that
>   stamping (which is done each 64 bytes) invalidates all WQEs
> - disable WQE shrinking if FW version is < 2.2.232, otherwise
>   we could get CQE with error for NOP, which might overflow the CQ

BTW, this is less code:

drivers/infiniband/hw/mlx4/cq.c      |   12 +-
drivers/infiniband/hw/mlx4/mlx4_ib.h |    2
drivers/infiniband/hw/mlx4/qp.c      |  206
+++++++++++++++++++++++++++++------
drivers/net/mlx4/alloc.c             |   16 ++
include/linux/mlx4/device.h          |    7 +
include/linux/mlx4/qp.h              |    4
6 files changed, 209 insertions(+), 38 deletions(-)

Note that some 30 lines of the insertions are comments, and there's
a sanity check in cq.c that we can get rid of (some 5 more lines).
Less scary now, isn't it?

-- 
MST