[ofa-general] RE: [PATCH 1/4] [NET_SCHED] explict hold dev tx lock
Waskiewicz Jr, Peter P
peter.p.waskiewicz.jr at intel.com
Mon Sep 24 12:12:49 PDT 2007
> I have submitted this before; but here it is again.
> Against net-2.6.24 from yesterday for this and all following patches.
>
>
> cheers,
> jamal
Hi Jamal,
I've been (slowly) working on resurrecting the original design
of my multiqueue patches to address this exact issue of the queue_lock
being a hot item. I added a queue_lock to each queue in the subqueue
struct, and in the enqueue and dequeue, just lock that queue instead of
the global device queue_lock. The only two issues to overcome are the
QDISC_RUNNING state flag, since that also serializes entry into the
qdisc_restart() function, and the qdisc statistics maintenance, which
needs to be serialized. Do you think this work along with your patch
will benefit from one another? I apologize for not having working
patches right now, but I am working on them slowly as I have some blips
of spare time.
Thanks,
-PJ Waskiewicz
More information about the general
mailing list