[ofa-general] [PATCH 3/11] ib_core: add checksum offload support

[Eli Cohen]

On Tue, 2007-09-25 at 12:57 +0200, Or Gerlitz wrote:

> I did not say that you need to add four capabilities, you can add one 
> that fits the connectX feature eg IB_DEVICE_HW_CSUM and document that if 
> the device supports this, it is capable to compute TCP and UDP checksum 
> for both IPv4 and IPv6 packets, etc. Later if some new HW will be 
> capable to offload only IPv4, they will add a new capability etc.
> 
OK, I will add a comment.

> Again, per the discussion over the thread it --is-- true, also, it 
> creates confusion while reading the code (why to ask the HW to do 
> something which is always done by SW?), also this does not put more work 
> on the private case of the connectX HW which relies on the IB ICRC, 
> second HW might go and actually compute the IP header csum.
> 
Mellanox HW does not rely in this case on IB ICRC. The HW really
computes checksum on outgoing packets.