[ofa-general] Re: [PATCH] osm/osm_sa_path_record: trivial cosmetic chage

[Sasha Khapyorsky]

Hi Yevgeny,

On 00:23 Tue 25 Sep     , Yevgeny Kliteynik wrote:
> Trivial fix in osm_sa_path_record.c
> 
> Signed-off-by:  Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
> ---
>  opensm/opensm/osm_sa_path_record.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/opensm/opensm/osm_sa_path_record.c b/opensm/opensm/osm_sa_path_record.c
> index 3b183d9..ce75ec8 100644
> --- a/opensm/opensm/osm_sa_path_record.c
> +++ b/opensm/opensm/osm_sa_path_record.c
> @@ -723,7 +723,7 @@ __osm_pr_rcv_get_path_parms(IN osm_pr_rcv_t * const p_rcv,
>  	if (pkey) {

Is this "if (pkey)" needed? Following flow above I found that pkey
should always be initialized. Right?

Sasha

>  		p_prtn =
>  		    (osm_prtn_t *) cl_qmap_get(&p_rcv->p_subn->prtn_pkey_tbl,
> -					       pkey & cl_ntoh16((uint16_t) ~
> +					       pkey & cl_hton16((uint16_t) ~
>  								0x8000));
>  		if (p_prtn ==
>  		    (osm_prtn_t *) cl_qmap_end(&p_rcv->p_subn->prtn_pkey_tbl))
> -- 
> 1.5.1.4
>