[ofa-general] Re: [PATCH] mlx4: display misc device information via sysfs under /sys/class/infiniband/mlx4_x, for ibstat and ibv_devinfo

[Roland Dreier]

Thanks, applied with the cleanup suggested by MST.  BTW when applying
I had to edit the patch, because of:

 > 	MLX4_MGM_ENTRY_SIZE	=  0x100,

this context didn't match the upstream kernel (I see 0x40 there).  Is
there some reason you have a bigger size in your tree?  If so should
we make the change upstream too?

Also I deobfuscated as below:

diff --git a/drivers/net/mlx4/main.c b/drivers/net/mlx4/main.c
index be3c6fc..9e590e1 100644
--- a/drivers/net/mlx4/main.c
+++ b/drivers/net/mlx4/main.c
@@ -524,8 +524,8 @@ static int __devinit mlx4_init_hca(struct mlx4_dev *dev)
 	}
 
 	priv->eq_table.inta_pin = adapter.inta_pin;
-	priv->dev.rev_id	= adapter.revision_id;
-	memcpy(priv->dev.board_id, adapter.board_id, sizeof priv->dev.board_id);
+	dev->rev_id		= adapter.revision_id;
+	memcpy(dev->board_id, adapter.board_id, sizeof dev->board_id);
 
 	return 0;