[ofa-general] Re: [PATCH 11/11]: mlx4_core use fixed CQ moderation paramters

[Michael S. Tsirkin]

> Quoting Roland Dreier <rdreier at cisco.com>:
> Subject: Re: [PATCH 11/11]: mlx4_core use fixed CQ moderation paramters
> 
>  > +static int cq_max_count = 16;
>  > +static int cq_period = 10;
>  > +
>  > +module_param(cq_max_count, int, 0444);
>  > +MODULE_PARM_DESC(cq_max_count, "number of CQEs to generate event");
>  > +module_param(cq_period, int, 0444);
>  > +MODULE_PARM_DESC(cq_period, "time in usec for CQ event generation");
> 
> I assume this is just a leftover from some earlier approach?  These
> module parameters are just ignored now, so the patch seems kind of
> pointless.

These should go into create CQ inbox. I'll recheck.

> Anyway I think the approach of having one global setting for all CQs
> is not a good one -- it seems likely that for example IPoIB and SDP
> would want different settings, not to mention userspace applications.

I agree. But what should be the default setting?
Consider also that there's currently no userspace API to control
event coalescing.

So global setting to control the defaults might still make sense. No?

-- 
MST