[ofa-general] Re: [PATCH] libibmad/dump: support VLArb table size, fix printing

[akepner at sgi.com]

On Sat, Mar 29, 2008 at 12:12:52PM +0000, Sasha Khapyorsky wrote:
> 
> Add support for VLArb table size. Fix printing, eliminate intermediate
> buffers, some other cleanups.
> 
> Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>
> ---
> 
> Arthur, could you try this?
> ....

Tested-by: Arthur Kepner <akepner at sgi.com>

Yes, I tried it (along with the infiniband-diags patch) and 
that fixes things. Thanks!

Before the patch was applied, I'd get:

# smpquery vlarb 2
# VLArbitration tables: Lid 2 port 0 LowCap 8 HighCap 8
# Low priority VL Arbitration Table:
VL    : |0x3 |
WEIGHT: |0x3 |

But the tables as reported by smpdump looked OK - the 
weird weights here are for experimentation, and they 
are correct:

# smpdump  2 0x18 0x00010000
0000 0101 0201 0301 0003 0103 0203 0303
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000

# smpdump  2 0x18 0x00030000
0002 0102 0202 0302 0008 0108 0208 0308
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000


After the patch is applied, smpquery does what I'd expect:

# smpquery vlarb 2
# VLArbitration tables: Lid 2 port 0 LowCap 8 HighCap 8
# Low priority VL Arbitration Table:
VL    : |0x0 |0x1 |0x2 |0x3 |0x0 |0x1 |0x2 |0x3 |
WEIGHT: |0x0 |0x1 |0x1 |0x1 |0x3 |0x3 |0x3 |0x3 |
# High priority VL Arbitration Table:
VL    : |0x0 |0x1 |0x2 |0x3 |0x0 |0x1 |0x2 |0x3 |
WEIGHT: |0x2 |0x2 |0x2 |0x2 |0x8 |0x8 |0x8 |0x8 |

-- 
Arthur