[ofa-general] Re: [PATCH] AMSO1100: Add check for NULL reply_msg in c2_intr

Roland Dreier rdreier at cisco.com
Fri Apr 4 12:22:06 PDT 2008


 > I don't think anyone has ever hit this bug, so it is a low priority in my view. I also noticed that
 > if we refactored vq_wait_for_reply that we could combine a common 
 > 
 > if (!reply) {
 > 	err = -ENOMEM;
 > 	goto bail;
 > }
 > 
 > construct by guaranteeing that reply is non-null if vq_wait_for_reply returns without
 > an error. This patch, however, is much smaller. What do you think?

Well, now is a good time to merge either version of the fix.  Would be
nice to kill off one of the Coverity issues so I'm happy to take this.

It's up to you how much effort you want to spend on this... the
refactoring sounds nice but I think we're OK without it.

 - R.



More information about the general mailing list