[ofa-general] inconsistent use of --with-backport[-patches]

[Brian J. Murrell]

I'm trying to help the 1.3 ofa_kernel package along with figuring out
which backport patches to use for my kernel source (because the kernel
version does not work nicely with ofed_patch.sh's get_backport_dir()
function) and there seems to be an inconsistent use of
--with-backport-patches between configure and ofed_patch.sh.

ofed_patch.sh takes the following arguments:

                        --with-backport-patches)
                                WITH_BACKPORT_PATCHES="yes"
                                WITH_PATCH="yes"
                        ;;
                        --without-backport-patches)
                                WITH_BACKPORT_PATCHES="no"
                        ;;
                        --with-backport)
				shift
                                BACKPORT_DIR=$1
                        ;;
                        --with-backport=*)
                                BACKPORT_DIR=`expr "x$1" : 'x[^=]*=\(.*\)'`
			;;

and configure takes the following backport patches arguements:

                        --with-backport-patches)
                                ofed_patch_params="$ofed_patch_params $1"
                        ;;
                        --without-backport-patches)
                                ofed_patch_params="$ofed_patch_params $1"
                        ;;

As you can see configure accepts "--with[out]-backport-patches <arg>"
arguments and simply passes them on to ofed_patch.sh, however it does
not accept the "--with-backport" argument to actually specify a set to
use.

b.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20080405/86c19af9/attachment.sig>