[ofa-general] Re: [PATCH] opensm/opensm/osm_subnet.c: add checks for HOQ and Leaf HOQ input values

[Hal Rosenstock]

On Wed, 2008-04-09 at 20:46 +0000, Sasha Khapyorsky wrote:
> On 08:38 Wed 09 Apr     , weiny2 at llnl.gov wrote:
> > 
> > What if we set it to 0x13?  This would be the maximum value that will not
> > "lock" up the fabric.  We could also add to the error message that the
> > admin needs to specify 0x14 if they specifically want "infinity" to be
> > set?
> 
> I think in the case when parameter value provided by user is wrong it
> is not easy to guess correctly what original wishes was. Probably we
> just need to add something like:
> 
>   ## valid values are <= 0x14
> 
> in config file template and reject any invalid values (I mean set to
> defaults)?

That's consistent with other invalid settings so maybe also add info on
valid values into opensm.opts to try to reduce the chance of this
occurring.

-- Hal

> Sasha
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general