> +int mlx4_fmr_alloc_reserved(struct mlx4_dev *dev, u32 mridx, > + u32 pd, u32 access, int max_pages, > + int max_maps, u8 page_shift, struct mlx4_fmr *fmr) So reading this over in more detail, I now really think it has to be split up. There are too many new things added without any users for it to be possible to review. - r.