[ofa-general] RE: [PATCH/RFC] RDMA/nes: Remove unneeded function declarations

Glenn Streiff gstreiff at NetEffect.com
Fri Apr 18 14:42:51 PDT 2008


Acked-by: Glenn Streiff <gstreiff at neteffect.com>

Thanks.

> -----Original Message-----
> From: Roland Dreier [mailto:rdreier at cisco.com]
> Sent: Friday, April 18, 2008 3:09 PM
> To: general at lists.openfabrics.org
> Cc: Faisal Latif; Nishi Gupta; Glenn Streiff
> Subject: [PATCH/RFC] RDMA/nes: Remove unneeded function declarations
> 
> 
> Remove redundant static declarations of functions that are defined
> before they are used in the source.
> 
> Signed-off-by: Roland Dreier <rolandd at cisco.com>
> ---
> diff --git a/drivers/infiniband/hw/nes/nes.c 
> b/drivers/infiniband/hw/nes/nes.c
> index b00b0e3..b046262 100644
> --- a/drivers/infiniband/hw/nes/nes.c
> +++ b/drivers/infiniband/hw/nes/nes.c
> @@ -96,12 +96,6 @@ static LIST_HEAD(nes_dev_list);
>  
>  atomic_t qps_destroyed;
>  
> -static void nes_print_macaddr(struct net_device *netdev);
> -static irqreturn_t nes_interrupt(int, void *);
> -static int __devinit nes_probe(struct pci_dev *, const 
> struct pci_device_id *);
> -static void __devexit nes_remove(struct pci_dev *);
> -static int __init nes_init_module(void);
> -static void __exit nes_exit_module(void);
>  static unsigned int ee_flsh_adapter;
>  static unsigned int sysfs_nonidx_addr;
>  static unsigned int sysfs_idx_addr;
> diff --git a/drivers/infiniband/hw/nes/nes_nic.c 
> b/drivers/infiniband/hw/nes/nes_nic.c
> index 3416664..01cd0ef 100644
> --- a/drivers/infiniband/hw/nes/nes_nic.c
> +++ b/drivers/infiniband/hw/nes/nes_nic.c
> @@ -92,15 +92,6 @@ static const u32 default_msg = 
> NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK
>  		| NETIF_MSG_IFUP | NETIF_MSG_IFDOWN;
>  static int debug = -1;
>  
> -
> -static int nes_netdev_open(struct net_device *);
> -static int nes_netdev_stop(struct net_device *);
> -static int nes_netdev_start_xmit(struct sk_buff *, struct 
> net_device *);
> -static struct net_device_stats *nes_netdev_get_stats(struct 
> net_device *);
> -static void nes_netdev_tx_timeout(struct net_device *);
> -static int nes_netdev_set_mac_address(struct net_device *, void *);
> -static int nes_netdev_change_mtu(struct net_device *, int);
> -
>  /**
>   * nes_netdev_poll
>   */
> 



More information about the general mailing list