[ofa-general] [PATCH] mlx4_core: enable changing default max HCA resource limits at run time -- reposting

[Hal Rosenstock]

On Mon, 2008-04-28 at 18:20 +0300, Jack Morgenstein wrote:
> On Monday 28 April 2008 18:02, Hal Rosenstock wrote:
> > In places where there are reserved resources (like qps, srqs, others ?),
> > should it be ensured that the parameters set are above the logs of those
> > amounts so the user doesn't shoot themselves in the foot by accident ?
> > 
> No worry there.  The reserved resources are subtracted from the above
> log amounts (when expressed as a power-of-2:  1UL << log), and the
> resulting amounts (<power-of-2> - reserved) returned to the user as
> the device limits.
> (check this out using ibv_devinfo)
> 
> Thus, the user CANNOT "shoot themselves in the foot".

Right; that accounts for the reserved ones but what happens if they
mistakenly set something like

log_num_qp = 5

where the total number is less than the reserved number ?

Should this be protected against in some way (friendly error or bump to
minimum needed) and/or indicate a minimum in the mod param description ?

> - Jack
> 
> (P.S. this patch is in OFED 1.3

Also, OFED 1.2.5.4

>  -- do "modinfo mlx4_core" to see the above module parameters ).

Thanks.

-- Hal