[ofa-general] Re: [PATCH] ib_mthca: use log values instead of numeric values when specifiying HCA resource maxes in module parameters

[Roland Dreier]

 > Module parameters for overriding driver default maximum HCA resource
 > quantities should be log values, not numeric values -- since these
 > quantities should all be powers-of-2 anyway.

Hmm, that's a creative answer to my objection about the mlx4 interface.

given that mthca has had the old interface for nearly a year and a half,
what do we gain from changing it now?

 > I put a check in the patch for detecting if the user specified a log or not,
 > to make the transition from the old method (of numbers instead of logs)
 > easier.

Yes, that is nice.  Would the plan be just to allow both methods?

 > Maybe add such a check to the mlx4 version, too?

Definitely, and I think the mlx4 module parameter names should match
too.  But then it would make sense for mlx4 to allow setting parameter
values by value and not by log, and then we end up with all the same
code in both places, and so why not just have mlx4 set by value the same
way as mthca?

 - R.