[ofa-general] Re: [ PATCH 3/3 ] RDMA/nes SFP+ cleanup
Roland Dreier
rdreier at cisco.com
Tue Apr 29 10:18:16 PDT 2008
> My bad, on the array index idiom. I can redo.
Yes, please do resend without that.
> With regard to post patch clean-ups, I recall you telling me
> that is was preferred to either front-load or back-load the
> cleanups in a patch series.
Yes, that is true.
> I generally "cleaned-up" the entire functions rather than
> just the patched portion. If I do both together, then you'll
> get clean-up noise interspersed with functional deltas making
> functional review somewhat annoying in my opinion.
OK, got it. The changelog "Clean up the SFP+ patch." was misleading.
- R.
More information about the general
mailing list