[ofa-general] Re: [PATCH} IB/iSER: Move high-volume debug output to higher debug levels

Roland Dreier rdreier at cisco.com
Tue Apr 29 10:33:37 PDT 2008


 > +module_param_named(debug_level, iser_debug_level, int,
 > S_IRUGO|S_IWUSR|S_IWGRP);
 > +MODULE_PARM_DESC(debug_level, "Enable debug tracing if > 0
 > (default:disabled)");

In addition to being line-wrapped this looks really funny... why add
S_IWGRP?  The ownership of parameter files is root:root so what do you
get from changing from the current 0644 permissions?

I applied the patch without this change, if there is a reason for this,
please send the permission change separately.

 - R.



More information about the general mailing list