[ofa-general] RE: [PATCH 1/1 v2] librdmacm: add support for create qp expanded (with changelog this time)

[Jack Morgenstein]

On Sunday 03 August 2008 14:27, Ron Livne wrote:
> What if the user wants to call rdma_create_qp_expanded with create_flags = 0,
> with intension that ibv_create_qp_expanded will be called with create_flags = 0.
> I know There's a pretty slim chance anyone would want to do so,
> because it does the same thing.
> But still...
> 
> Ron
> 
I've come around to agreeing with you. Since this is an internal function we are talking about,
we're probably better off having a separate flag which indicates whether it was invoked by
rmda_create_qp() or rdma_create_qp_expanded().  That way, we do not limit the future behavior
of ibv_create_qp_expanded() (by having the librdmarc library depend on knowledge of the internal
behavior of ibv_create_qp_expanded() ).

- Jack