[ofa-general] [PATCH 1/5] [uDAPL v2] dapl scm: update max_rdma_read_iov, max_rdma_write_iov EP attributes during query
Steve Wise
swise at opengridcomputing.com
Fri Aug 15 04:13:14 PDT 2008
Arlin Davis wrote:
> >From 7e25c0f21d755cce3aa7aff993fb0baddaafc0e8 Mon Sep 17 00:00:00 2001
> From: Arlin Davis <arlin.r.davis at intel.com>
> Patch set for uDAPL v2 socket cm provider improvements.
>
> Signed-off by: Arlin Davis ardavis at ichips.intel.com
> ---
> dapl/openib_scm/dapl_ib_util.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/dapl/openib_scm/dapl_ib_util.c b/dapl/openib_scm/dapl_ib_util.c
> index 43f85ac..f3874ca 100644
> --- a/dapl/openib_scm/dapl_ib_util.c
> +++ b/dapl/openib_scm/dapl_ib_util.c
> @@ -478,6 +478,8 @@ DAT_RETURN dapls_ib_query_hca (
> ep_attr->max_request_iov = dev_attr.max_sge;
> ep_attr->max_rdma_read_in = dev_attr.max_qp_rd_atom;
> ep_attr->max_rdma_read_out= dev_attr.max_qp_rd_atom;
> + ep_attr->max_rdma_read_iov= dev_attr.max_sge;
> + ep_attr->max_rdma_write_iov= dev_attr.max_sge;
> dapl_dbg_log (DAPL_DBG_TYPE_UTIL,
> " query_hca: MAX msg %llu mtu %d dto %d iov %d"
> " rdma i%d,o%d\n",
>
This breaks iwarp which only allows 1 SGE for the local SGL in an rdma
read. I thought dev.max_qp_rd_atom indicated this value, not max_sge.
So either this patch is wrong, or the rdma device attrs need to be
enhanced to separate max_read_sge as a stand-alone attr.
Steve.
More information about the general
mailing list