[ofa-general] Compile error: NULL isn't defined in dat/common/dat_strerror.c

[Harold/Carlyn Iuzzolino]

Dear Openfabrics and Arlin Davis 
general at lists.openfabrics.org arlin.r.davis at intel.com

On August 6th I reported a bug, Number 1120, that 
In subroutine dat_strerror.c NULL isn't defined.

Which of the .h files, dat_dr.h, dat_sr.h, <dat/kdat.h>, <dat/udat.h>
do you need to include in dat_strerror.c so that
NULL gets defined?


I am using a Fedora 9, Athlon 64X4 bit machine.

[root at treebeard OFED-1.4-20080816-0600]# cat /etc/issue
Fedora release 9 (Sulphur)
Kernel \r on an \m (\l)

[root at treebeard OFED-1.4-20080816-0600]# uname -a
Linux treebeard 2.6.25-14.fc9.x86_64 #1 SMP Thu May 1 06:06:21 EDT 2008 x86_64 x86_64 x86_64 GNU/Linux



As far as I can tell, this bug hasn't been fixed in the last 4 versions and because of the way the OFED software is packaged, ie a tar file of rpms which
have tar.gz files inside, I can't try to fix it myself and then run install.pl
again.

[root at treebeard root]# md5sum `ff compat-dapl-1.2.8.tar.gz`
39a825669913ff4622ee2b120a9a7409  ./OFED-1.4-20080816-0600.var.tmp/OFED_topdir/SOURCES/compat-dapl-1.2.8.tar.gz
39a825669913ff4622ee2b120a9a7409  ./OFED-1.4-20080813-0600.var.tmp/OFED_topdir/SOURCES/compat-dapl-1.2.8.tar.gz
39a825669913ff4622ee2b120a9a7409  ./OFED-1.4-20080803-0600.var.tmp/OFED_topdir/SOURCES/compat-dapl-1.2.8.tar.gz
39a825669913ff4622ee2b120a9a7409  ./OFED-1.4-20080811-0819.var.tmp/OFED_topdir/SOURCES/compat-dapl-1.2.8.tar.gz


 
I downloaded version OFED-1.4-20080813-0600.tar.gz
and then later, OFED-1.4-20080816-0600.tar.gz 
and tried installing it/them. No luck. Error in the same spot.

Build compat-dapl RPM
Running  rpmbuild --rebuild --define '_topdir /var/tmp/OFED_topdir' --define 'dist ' --target x86_64 --define '_prefix /usr' --define '_exec_prefix /usr' --define '_sysconfdir /etc' --define '_defaultdocdir /usr/share/doc/compat-dapl-1.2.8' --define '_usr /usr' /root/OFED-1.4-20080813-0600/SRPMS/compat-dapl-1.2.8-1.src.rpm
Failed to build compat-dapl RPM
See /tmp/OFED.32320.logs/compat-dapl.rpmbuild.log


 gcc -DHAVE_CONFIG_H -I. -I. -I. -Wall -g -D_GNU_SOURCE -DOS_RELEASE=131078 -I./dat/include/ -I./dat/udat/ -I./dat/udat/linux -I./dat/common/ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -MT dat_udat_libdat_la-dat_dictionary.lo -MD -MP -MF .deps/dat_udat_libdat_la-dat_dictionary.Tpo -c dat/common/dat_dictionary.c -o dat_udat_libdat_la-dat_dictionary.o >/dev/null 2>&1
dat/common/dat_strerror.c: In function 'dat_strerror':
dat/common/dat_strerror.c:621: error: 'NULL' undeclared (first use in this function)
dat/common/dat_strerror.c:621: error: (Each undeclared identifier is reported only once
dat/common/dat_strerror.c:621: error: for each function it appears in.)
make[2]: *** [dat_udat_libdat_la-dat_strerror.lo] Error 1



Because of the way the install.pl script works, I have to wait for someone 
to fix it, and make a new OFED-1.4-200808xx-0600.tar.gz.

I am puzzled that this problem hasn't occurred for everyone who tries
to compile. But, please could someone fix this. I can't continue compiling
until it is fixed.


Carlyn Iuzzolino