[ofa-general] Re: [PATCH 10/10] RDMA/nes: Add loopback check to make_cm_node()

[Roland Dreier]

Thanks, I applied the following patches:

Chien Tung (2):
      RDMA/nes: Add loopback check to make_cm_node()
      RDMA/nes: Cleanup warnings

Faisal Latif (6):
      RDMA/nes: Cleanup cqp_request list usage
      RDMA/nes: Lock down connected_nodes list while processing it
      RDMA/nes: Avoid race between MPA request and reset event to rdma_cm
      RDMA/nes: Forward packets for a new connection with stale APBVT entry
      RDMA/nes: Fix TCP compliance test failures
      RDMA/nes: Check cqp_avail_reqs is empty after locking the list

A couple of trivial things you could do that would make my life a little
easier: the body of your patch email currently looks like:

 > From:  Chien Tung <chien.tin.tung at intel.com>
 > 
 > RDMA/nes: Add loopback check to make_cm_node()
 > 
 > Check for loopback connection in make_cm_node()
 > 
 > Signed-off-by: Chien Tung <chien.tin.tung at intel.com>
 > --
 > diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c

The "From:" line is perfect, it gets the author correct in git
automatically.  However the line after that with the changelog subject
shouldn't be there -- git will automatically use the "Subject:" line of
the email itself for the patch title, and so I just have to strip the
duplicate subject by hand to avoid it showing up in git twice.  Also the
"--" is not quite right -- it needs to be "---" (three '-'s, not two)
for git to strip it automatically; as it stands I get a "--" in the
changelog after your signoff unless I strip it by hand.  And also
including a diffstat after the "---" is helpful, so I can see what the
patch touches.

Using "git format-patch" possibly combined with "git send-email" is an
easy way to get things right.

 - R.