[ofa-general] Re: [PATCH 2/11] drivers/infiniband: Move a dereference below a NULL test

[Roland Dreier]

 > --- a/drivers/infiniband/hw/nes/nes_cm.c
 > +++ b/drivers/infiniband/hw/nes/nes_cm.c
 > @@ -376,13 +376,14 @@ int schedule_nes_timer(struct nes_cm_node *cm_node, struct sk_buff *skb,
 >  		int close_when_complete)
 >  {
 >  	unsigned long  flags;
 > -	struct nes_cm_core *cm_core = cm_node->cm_core;
 > +	struct nes_cm_core *cm_core;
 >  	struct nes_timer_entry *new_send;
 >  	int ret = 0;
 >  	u32 was_timer_set;
 >  
 >  	if (!cm_node)
 >  		return -EINVAL;
 > +	cm_core = cm_node->cm_core;

Thanks... I believe this is already taken care of by a patch pending for
2.6.29 (which should be in -next) that removes the test for NULL.

 - R.