[ofa-general] Bugs in opensm/libvendor
Sasha Khapyorsky
sashak at voltaire.com
Thu Dec 18 07:48:08 PST 2008
On 10:18 Thu 18 Dec , Hal Rosenstock wrote:
>
> > I don't expect any hurt for osmtest (however didn't check this yet).
>
> Depends on what you mean by hurt:
>
> osmtest/osmtest.c: req.query_type = OSMV_QUERY_PATH_REC_BY_PORT_GUIDS;
> osmtest/osmtest.c: req.query_type = OSMV_QUERY_PATH_REC_BY_GIDS;
> osmtest/osmtest.c: req.query_type = OSMV_QUERY_PATH_REC_BY_LIDS;
> osmtest/osmtest.c: req.query_type = OSMV_QUERY_PATH_REC_BY_PORT_GUIDS;
>
> So in line with your approach, these instances should be changed over
> to user specified ones.
Look closer how it is used there - it is transparent to num_paths
returned. I don't think we need to change something in osmtest.
> Also, IMO saquery should support both compliant and extended queries.
If somebody cares I can accept the patch with '--complaint' option
implemented.
Sasha
More information about the general
mailing list