[ofa-general] Patch for libvendor incompatibility with QLogic SM

[Hal Rosenstock]

Mike,

On Thu, Dec 18, 2008 at 2:18 PM, Mike Heinz <michael.heinz at qlogic.com> wrote:
> Sets the num_path attribute of the path record for path queries, to comply with the IBTA spec while supporting the opensm extended functionality.

Actually, given the discussion, (nit) I don't think this patch does
anything in terms of supporting the opensm extended functionality.

> Signed-off-by: mheinz at qlogic.com (Michael Heinz)

Another nit...

Usual format is:

Signed-off-by: Michael Heinz <mheinz at qlogic.com>

> --------------------------------
> --- osm_vendor_ibumad_sa.c.orig 2008-10-20 01:00:09.000000000 -0400
> +++ osm_vendor_ibumad_sa.c      2008-12-18 14:13:05.000000000 -0500
> @@ -615,7 +615,8 @@
>                sa_mad_data.attr_offset =
>                    ib_get_attr_offset(sizeof(ib_path_rec_t));
>                sa_mad_data.comp_mask =
> -                   (IB_PR_COMPMASK_DGID | IB_PR_COMPMASK_SGID);
> +                   (IB_PR_COMPMASK_DGID | IB_PR_COMPMASK_SGID | IB_PR_COMPMASK_NUMBPATH);
> +               path_rec.num_path = 0x7f;
>                sa_mad_data.p_attr = &path_rec;
>                ib_gid_set_default(&path_rec.dgid,
>                                   ((osmv_guid_pair_t *) (p_query_req->
> @@ -634,7 +635,8 @@
>                sa_mad_data.attr_offset =
>                    ib_get_attr_offset(sizeof(ib_path_rec_t));
>                sa_mad_data.comp_mask =
> -                   (IB_PR_COMPMASK_DGID | IB_PR_COMPMASK_SGID);
> +                   (IB_PR_COMPMASK_DGID | IB_PR_COMPMASK_SGID | IB_PR_COMPMASK_NUMBPATH);
> +               path_rec.num_path = 0x7f;
>                sa_mad_data.p_attr = &path_rec;
>                memcpy(&path_rec.dgid,
>                       &((osmv_gid_pair_t *) (p_query_req->p_query_input))->
> @@ -652,7 +654,8 @@
>                sa_mad_data.attr_offset =
>                    ib_get_attr_offset(sizeof(ib_path_rec_t));
>                sa_mad_data.comp_mask =
> -                   (IB_PR_COMPMASK_DLID | IB_PR_COMPMASK_SLID);
> +                   (IB_PR_COMPMASK_DLID | IB_PR_COMPMASK_SLID | IB_PR_COMPMASK_NUMBPATH);
> +               path_rec.num_path = 0x7f;
>                sa_mad_data.p_attr = &path_rec;
>                path_rec.dlid =
>                    ((osmv_lid_pair_t *) (p_query_req->p_query_input))->
> --

Shouldn't there be a similar patch for osm_vendor_mlx_sa.c ? I thought
you had this originally.

-- Hal

> Michael Heinz
> Principal Engineer, Qlogic Corporation
> King of Prussia, Pennsylvania
>
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>