[ofa-general] Re: [PATCH V2 1/3] Create a new library libibnetdisc
Roland Dreier
rdreier at cisco.com
Tue Dec 23 15:43:46 PST 2008
> Also that is in the test code (libibnetdisc/test/iblinkinfotest.c). The real
> iblinkinfo has them all declared static.
>
> void
> print_port(ibnd_node_t *node, ibnd_port_t *port)
> {
> static char remote_guid_str[256];
> static char remote_str[256];
so this function is not thread-safe.... This seems to be setting an
unnecessary booby-trap; is there a reason not to put these variables on
the stack?
More information about the general
mailing list