[ofa-general] Re: [PATCH 3/4] ipoib: fix a deadlock between ipoib start/stop and child interface create/delete

Roland Dreier rdreier at cisco.com
Tue Dec 30 16:15:20 PST 2008


 > +	atomic_t vlan_task_flag;

why is this atomic_t?  I only see:

 > +		atomic_set(&priv->vlan_task_flag, 1);
 > +		atomic_set(&priv->vlan_task_flag, 0);
 > +	iffup_value = atomic_read(&priv->vlan_task_flag) ? IFF_UP : 0;

so as far as I can tell you are not using anything atomic.  So if
there's a race you're worried about, it's still there...

 - R.



More information about the general mailing list