[ofa-general] uDAPL libdat2.so version [PATCH] udapl v1 and v2 - dat_create_psp_any() seed value wrong

[Tang, Changqing]

Yes, the error is from  dat_psp_create_any().

After changing seed value to 1024, do I still get any warning message ?

Can I get this fix from tomorow's tarball ?


--CQ


> -----Original Message-----
> From: Arlin Davis [mailto:ardavis at ichips.intel.com]
> Sent: Thursday, February 07, 2008 5:05 PM
> To: Tang, Changqing
> Cc: OpenFabrics General
> Subject: Re: [ofa-general] uDAPL libdat2.so version [PATCH]
> udapl v1 and v2 - dat_create_psp_any() seed value wrong
>
> Arlin Davis wrote:
> > Tang, Changqing wrote:
> >> Arlin:
> >>         Thank you for pointing this out, I almost forgot this
> >> mismatch
> >
> > If calling dat_psp_create_any(), the seed value is 1000 so you will
> > get some warning messages until it hits a valid port. This
> is not an
> > error just a warning.
>
> Actually this will return an ERR. Here is a patch to fix both
> v1 and v2 providers.
>
> Change PSP seed value to start with non-privileged port mappings.
>
> Signed-off by: Arlin Davis <ardavis at ichips.intel.com>
>
> diff --git a/dapl/common/dapl_psp_create_any.c
> b/dapl/common/dapl_psp_create_any.c
> index a2768fb..e2faa4a 100644
> --- a/dapl/common/dapl_psp_create_any.c
> +++ b/dapl/common/dapl_psp_create_any.c
> @@ -82,7 +82,7 @@ dapl_psp_create_any (
>       DAPL_SP            *sp_ptr;
>       DAPL_EVD           *evd_ptr;
>       DAT_RETURN         dat_status;
> -    static DAT_CONN_QUAL hint_conn_qual = 1000;        /*
> seed value */
> +    static DAT_CONN_QUAL hint_conn_qual = 1024;        /*
> seed value */
>       DAT_CONN_QUAL      lcl_conn_qual;
>       DAT_CONN_QUAL      limit_conn_qual;
>
>
>