[ofa-general] Re: [PATCH 4/16 v4] IB/ipoib: Add checksum offload	support
    Roland Dreier 
    rdreier at cisco.com
       
    Fri Feb  8 14:45:16 PST 2008
    
    
  
I'm a little worried here:
 > +		if (priv->ca->flags & IB_DEVICE_IP_CSUM)
 > +			dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;
I don't see any place that ca->flags ever gets set; in fact if I
delete the flags member of struct ib_device from my tree, it all still
compiles fine.
So have you actually tested any of these checksum offload code paths?
 - R.
    
    
More information about the general
mailing list