[ofa-general] Re: [PATCH 4/16 v4] IB/ipoib: Add checksum offloadsupport

Or Gerlitz ogerlitz at voltaire.com
Tue Feb 12 00:56:16 PST 2008


Roland Dreier wrote:
> Seems strange to use device->flags for just the checksum
> offload stuff and device_cap_flags for everything else though.  I
> don't see any major issues with moving device_cap_flags into struct
> ib_device and not forcing a device query call

I also don't see major issue with this approach, but for better 
isolation between the ULPs and HW drivers, I would prefer to remain with 
the approach that requires the ULP to issue device query.

Or.




More information about the general mailing list