[ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.

[Diego Guella]

One question below


----- Original Message ----- 
From: "Roland Dreier" <rdreier at cisco.com>
To: "Steve Wise" <swise at opengridcomputing.com>
Cc: <netdev at vger.kernel.org>; <linux-kernel at vger.kernel.org>; <general at lists.openfabrics.org>
Sent: Wednesday, February 13, 2008 1:26 AM
Subject: Re: [ofa-general] [PATCH 2.6.25] RDMA/cxgb3: Fail loopbackconnections.


> applied, although:
> 
> > +static void is_loopback_dst(struct iw_cm_id *cm_id)
> > +{
> > + struct net_device *dev;
> > + 
> > + dev = ip_dev_find(&init_net, cm_id->remote_addr.sin_addr.s_addr);
> > + if (!dev)
> > + return 0;

how can a static void function return 0?
%)

> > + dev_put(dev);
> > + return 1;

same here