[ofa-general] Re: [PATCH] qperf: seg fault in help

Johann George johann.george at qlogic.com
Wed Feb 13 10:04:28 PST 2008


Yevgeny,

Thanks.  It has been applied.

Johann

On Wed, Feb 13, 2008 at 02:02:16PM +0200, Yevgeny Kliteynik wrote:
> Hi Johann,
> 
> Running "qperf --help SOME_WRONG_STRING" will fail with core dump.
> The following patch should fix it.
> Please apply to ofed_1_3 and master.
> 
> Thanks
> 
> -- Yevgeny
> 
> Signed-off-by:  Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
> ---
>  src/qperf.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qperf.c b/src/qperf.c
> index f38247d..dbeae5d 100644
> --- a/src/qperf.c
> +++ b/src/qperf.c
> @@ -713,7 +713,7 @@ do_option(OPTION *option, char ***argvp)
>              if (streq(*usage, category))
>                  break;
>          if (!*usage)
> -            error(0, "cannot find help category %s; try: qperf --help");
> +            error(0, "cannot find help category %s; try: qperf --help", category);
>          printf("%s", usage[1]);
>          exit(0);
>      } else if (streq(t, "host")) {
> -- 
> 1.5.1.4
> 



More information about the general mailing list