[ofa-general] Re: [PATCH] opensm:osm_console cleanup, rename, reorg, no new functionality

[Sasha Khapyorsky]

On 16:15 Thu 14 Feb     , Timothy A. Meier wrote:
>  Sasha,
> 
>  This patch prepares the console code to accept changes needed for an OpenSSL 
>  connection.
> 
>  It doesn't contain new functionality, but should make integrating new 
>  features easier and more clear.
> 
>  -- 
>  Timothy A. Meier
>  Computer Scientist
>  ICCD/High Performance Computing
>  925.422.3341
>  meier3 at llnl.gov

> From 559434fc86ad689e5e97aa0d757c73ad6ebe7bc2 Mon Sep 17 00:00:00 2001
> From: Tim Meier <meier3 at llnl.gov>
> Date: Thu, 14 Feb 2008 15:57:02 -0800
> Subject: [PATCH] opensm:osm_console  cleanup, rename, reorg, no new functionality
> 
> These changes support the addition of an ssl connection for the
> console.  Some name changes were made to more accurately reflect
> usage.
> 
> Signed-off-by: Tim Meier <meier3 at llnl.gov>

Applied (small nit is below). Thanks.

> ---
>  opensm/include/opensm/osm_opensm.h |    4 +
>  opensm/opensm/osm_console.c        |  170 +++++++++++++++++++++--------------
>  2 files changed, 106 insertions(+), 68 deletions(-)

[snip...]

> +/**********************************************************************
> + * Do authentication & authorization check
> + **********************************************************************/
> +static int is_authorized(osm_console_t *p_oct)
> +{
> +#ifdef ENABLE_OSM_CONSOLE_SOCKET
> +  /* allowed to use the console? */
> +  p_oct->authorized = !is_remote(p_oct->client_type) || 
> +                       hosts_ctl(OSM_DAEMON_NAME, p_oct->client_hn, p_oct->client_ip, "STRING_UNKNOWN");
> +#else
> +  p_oct->authorized = 1;
> +#endif
> +  return p_oct->authorized;
> +}

This function is used only when ENABLE_OSM_CONSOLE_SOCKET is set. When
not gcc generates unused function warning. I fixed it already during
review.

Sasha