[ofa-general] Re: [PATCH] Fix 2 potential core dumps now that osm_node_get_physp_ptr can return NULL

[Ira Weiny]

On Thu, 21 Feb 2008 12:02:49 +0200
Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il> wrote:

> Sasha Khapyorsky wrote:
> > Hi Ira,
> > 
> > On 14:02 Wed 20 Feb     , Ira Weiny wrote:
> >> I actually hit these when I was testing with a low OSM_UMAD_MAX_PENDING value.
> >> I was a bit unsure of what to do in these cases if p_physp was NULL.  What I do
> >> in this patch seems reasonable as the fabric does route but perhaps you could
> >> double check me?
> > 
> > The patch looks correct for me. And seems I need to review all
> > osm_node_get_physp_ptr() usages again.
> > 
> >> From 310a6cceca946fcc86f7bec28dfdeba77d011fc5 Mon Sep 17 00:00:00 2001
> >> From: Ira K. Weiny <weiny2 at llnl.gov>
> >> Date: Wed, 20 Feb 2008 13:53:51 -0800
> >> Subject: [PATCH] Fix 2 potential core dumps now that osm_node_get_physp_ptr can return NULL
> >>
> >>
> >> Signed-off-by: Ira K. Weiny <weiny2 at llnl.gov>
> > 
> > Applied. Thanks.
> 
> Is this applicable to ofed_1_3 as well?

No, osm_node_get_physp_ptr does not return NULL in ofed_1_3.

Ira

> 
> -- Yevgeny
> 
> > Sasha
> > _______________________________________________
> > general mailing list
> > general at lists.openfabrics.org
> > http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> > 
> > To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
> >