[ofa-general] Re: Merging of completely unreviewed drivers
Greg KH
greg at kroah.com
Thu Feb 21 13:30:37 PST 2008
On Thu, Feb 21, 2008 at 11:01:24PM +0200, Adrian Bunk wrote:
>
> BTW: Greg, you are Cc'ed for your joke in [3]...
> [3] http://lkml.org/lkml/2008/2/12/427
That was not a joke, I ment it. Do you have proof that the majority of
patches going into the kernel tree are not reviewed by at least 2
people? Now they might not be 2 people that you personally like/agree
with, but that's a totally different topic...
And I'm with Linus on this one, it's much easier to work on driver fixes
together with others, when they are in the kernel tree.
Although I do like the checkpatch.pl script, it has helped me in making
it easier to clean up some vendor-provided drivers recently, finding
some obvious coding style issues that I had missed the first pass
through.
thanks,
greg k-h
More information about the general
mailing list