[ofa-general] Re: [PATCH RFC] opensm/ib_types.h: remove ifdef WIN conditions

[Sasha Khapyorsky]

On 09:00 Tue 08 Jan     , Hal Rosenstock wrote:
> On Tue, 2008-01-08 at 17:04 +0000, Sasha Khapyorsky wrote:
> > On 08:32 Tue 08 Jan     , Hal Rosenstock wrote:
> > > On Tue, 2008-01-08 at 16:38 +0000, Sasha Khapyorsky wrote:
> > > > On 07:57 Tue 08 Jan     , Hal Rosenstock wrote:
> > > > > > > Also, ib_cm_types.h looks like it should be changed as well in terms of
> > > > > > > this.
> > > > > > 
> > > > > > This file seems to be unused at all, likely we could just remove it.
> > > > > 
> > > > > This was done for an out of tree consumer a while ago (those definitions
> > > > > were originally in ib_types.h). There was a thread on general a while
> > > > > ago on this and I think a closed bug too. I can dig it out if you can't.
> > > > 
> > > > I remember at least discussion in bag tracker. So what is you opinion?
> > > 
> > > I would do the same thing here as being done with ib_types.h (and remove
> > > the WIN declarations) assuming no objections on this in general (e.g. on
> > > ib_types.h).
> > > 
> > > > Are you against removing?
> > > 
> > > Yes.
> > 
> > Why? Does anybody this file?
> 
> I don't know for sure but the change was requested a while ago

As far as I remember the request was to remove CM_* definitions from
ib_types.h.

> and I
> don't see what's so important in removing it.

It is easily to remove rather than cleanup an unneeded stuff.

Sasha