[ofa-general] Re: [PATCH] RDMA/cxgb3: Endianness annotation

[Steve Wise]

Roland Dreier wrote:
> Steve, is this change correct?  The only place the irs field is
> assigned to is with cpu_to_be32().  If it looks good, I'll merge it
> for 2.6.25...
> 
> diff --git a/drivers/infiniband/hw/cxgb3/cxio_wr.h b/drivers/infiniband/hw/cxgb3/cxio_wr.h
> index c84d4ac..de366b0 100644
> --- a/drivers/infiniband/hw/cxgb3/cxio_wr.h
> +++ b/drivers/infiniband/hw/cxgb3/cxio_wr.h
> @@ -315,7 +315,7 @@ struct t3_rdma_init_wr {
>  	__be32 ird;
>  	__be64 qp_dma_addr;	/* 7 */
>  	__be32 qp_dma_size;	/* 8 */
> -	u32 irs;
> +	__be32 irs;
>  };
>  
>  struct t3_genbit {

Yes, the irs field should be __be32.

Thanks,

Steve.