[ofa-general] ipoib_start_xmit Gratuitous ARP / bonding failover handling not applied on connected mode neighbours?!

[Roland Dreier]

 > Looking on ipoib_start_xmit, it seems that both the check that
 > comes to handle a gratitious ARP (ie a difference between the
 > remote GID as kept in the ipoib_neigh to the one present in the
 > network stack neighbour) and the check that comes to handle a
 > situation where we attempt to xmit an ipoib_neigh created by
 > another ipoib device (ie following a bonding failover) - does not
 > come into play for the connected mode neighbours.
 > 
 > Isn't it a bug, or I miss something?

Good question.  The device test came straight from Moni's patch -- how
much have you guys tested bonding of IPoIB CM?

The GID comparison seems a little trickier to handle -- it seems on a
neighbour GID change we need to tear down any connection we might have
in the CM case...