[ofa-general] [PATCH 14/16] ib/ipoib: Support modifying IPOIB CQ moderation params

[Eli Cohen]

On Thu, 2008-01-17 at 15:22 +0200, Or Gerlitz wrote:
> Eli Cohen wrote:
> > Support modifying IPOIB CQ moderation params
> > 
> > This can be used to tune at run time the paramters controlling
> > the event (interrupt) generation rate and thus reduce the overhead
> > incurred by handling interrupts resulting in better throughput.
> 
> IPoIB has one CQ. As I see it, this means that you should either let the 
> user specify only one of rx or tx coalescing params, or make sure that 
> the user did not provide something that the driver can not deploy, eg 
> rx_usecs 12 tx_usecs 1
I think making sure you can't provide two different values for rx and tx
will do.

> 
> > +static int ipoib_set_coalesce(struct net_device *dev,
> > +                             struct ethtool_coalesce *coal)
> > +	coal->tx_coalesce_usecs = coal->rx_coalesce_usecs;
> > +	priv->etool.coalesce_usecs = coal->rx_coalesce_usecs;
> > +	coal->rx_max_coalesced_frames = coal->rx_max_coalesced_frames;
> 
> I guess you wanted to say here coal->tx_max_coalesced_frames =
> 
> Or
> 
Yes, thanks.