[ofa-general] [PATCH 2/2] Update %install section of librdmacm spec file

Roland Dreier rdreier at cisco.com
Sat Jan 19 13:55:46 PST 2008


Change from using the %makeinstall macro to using "make install"
directly.  The page <http://fedoraproject.org/wiki/Packaging/Guidelines>
has this to say:

  "Fedora's RPM includes a %makeinstall macro but it must NOT be used
   when make install DESTDIR=%{buildroot} works. %makeinstall is a kludge....
   It is error-prone and can have unexpected effects....
   It can trigger unnecessary and wrong rebuilds....
   ....it can cause broken *.la files to be installed....
   Instead, Fedora packages should use: make DESTDIR=%{buildroot}
   install or make DESTDIR=$RPM_BUILD_ROOT install"

The librdmacm package uses automake, which means that the "make
DESTDIR=... install" method works fine, so we should use it.

Signed-off-by: Roland Dreier <rolandd at cisco.com>
---
 librdmacm.spec.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/librdmacm.spec.in b/librdmacm.spec.in
index 2fab9d4..415367b 100644
--- a/librdmacm.spec.in
+++ b/librdmacm.spec.in
@@ -39,7 +39,7 @@ make %{?_smp_mflags}
 
 %install
 rm -rf $RPM_BUILD_ROOT
-%makeinstall
+make DESTDIR=$RPM_BUILD_ROOT install
 # remove unpackaged files from the buildroot
 rm -f $RPM_BUILD_ROOT%{_libdir}/*.la
 



More information about the general mailing list