[ofa-general] Re: InfiniBand/RDMA merge plans for 2.6.25

[Glenn Streiff]

> From: general-bounces at lists.openfabrics.org
> [mailto:general-bounces at lists.openfabrics.org]On Behalf Of 
> Roland Dreier
> Sent: Tuesday, January 22, 2008 3:56 PM
> To: Christoph Hellwig
> Cc: linux-kernel at vger.kernel.org; general at lists.openfabrics.org
> Subject: [ofa-general] Re: InfiniBand/RDMA merge plans for 2.6.25
> 
> 
>  > >  - Neteffect "nes" driver.  It's not terribly clean code 
> but since
>  > >    it's a new driver that is completely self-contained, I plan on
>  > >    merging it and letting cleanups happen upstream.
>  > 
>  > New code should be better quality than old code, not 
> worse.   I haven't
>  > actually seen the driver yet, but by that statement I'd be clearly
>  > against a merge.
> 
> The driver has been posted a few times; the latest code is in the
> "neteffect" branch of my tree:
> 
>     
> git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniban
> d.git neteffect
> 
> It's not *that* bad -- certainly there are lots of things that could
> be improved (sparse endianness annotation, too many lines that are way
> to long, strange indentation of case labeles, etc, etc) but it is a
> self-contained hardware driver.  I agree with Linus's position (stated
> at the last kernel summit) that we ought to merge hardware drivers
> early, so that users get the drivers with as little hassle as
> possible.  We lose a little leverage in getting cleanups done, but the
> number of people who see the code and are able to clean it up
> increases, so I think it's a good trade-off.
> 
>  - R.
> 

My view is the code should and will be cleaned up based upon
the feedback we've gotten from the community.  It is a priority
for me.

Several cleanup fixes are in the queue and are being worked.
Haven't slipped into complacency at the prospect of the merge.

Glenn
gstreiff at neteffect.com