[ofa-general] Re: [PATCH] infiniband-diags/scripts/iblinkinfo.pl: Fix switch to switch output with new ibnetdiscover output.
Sasha Khapyorsky
sashak at voltaire.com
Sat Jan 26 04:22:00 PST 2008
On 19:02 Thu 24 Jan , Ira Weiny wrote:
> I am not sure when the "port guid output" format change to ibnetdiscover
> happened, but I just realized that switch to switch links were not being parsed
> correctly by IBswcountlimits.pm. This caused issues with some of the perl
> diags. I have fixed this. Furthermore, Erez mentioned that he would like port
> guid output so I threw that option in as well. (Since I have to parse that
> info out of ibnetdiscover now.)
>
> One might wonder why I did not catch this before? If you mainly test on a 1
> switch system you don't get to see what switch to switch links look like in
> diag output... :-( I have learned my lesson, sorry.
>
> Sasha, this needs to be in 1.3 as well.
>
> Sorry, :-(
> Ira
>
>
> From 89887aff392b0f40acf4035c19e06359271dfe6a Mon Sep 17 00:00:00 2001
> From: Ira K. Weiny <weiny2 at llnl.gov>
> Date: Thu, 24 Jan 2008 18:50:38 -0800
> Subject: [PATCH] infiniband-diags/scripts/iblinkinfo.pl: Fix switch to switch output with new
> ibnetdiscover output.
>
> ibnetdiscover now prints port guids. This format change cause the regex to
> break when parsing switch to switch links. Fix this by parsing for the
> remote port guid. And while we are at it add an option to print the port
> guids parsed.
>
> Signed-off-by: Ira K. Weiny <weiny2 at llnl.gov>
Applied. Thanks.
Sasha
More information about the general
mailing list