[ofa-general] [PATCH 2/3] RDMA/cxgb3: fix page shift calculation in build_phys_page_list()

[Bryan S Rosenburg]

Steve Wise <swise at opengridcomputing.com> wrote on 01/28/2008 11:55:00 AM:
> So is cxgb3 still busted?  IE I still need that additional patch you 
> sent?  Perhaps I can align cxgb3 and mthca to the same logic.  Maybe 
> create a core helper function...

As far as I can tell, cxgb3 is still busted for single-element buffer 
lists.  But you have an easy fix, which is what the first patch was about.

However, with the approach you've taken, you've given up some potential 
uses of larger page sizes.  To pick up those cases, you'd have to make the 
virtual address available to the page shift calculation in 
cxgb3:build_phys_page_list().  A core helper function shared with mthca 
and perhaps others sounds like a great idea to me, but I'm new to this 
community.  I don't know how much agreement you'd have to get.

- Bryan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20080128/a5a6d66c/attachment.html>