[ofa-general] Re: [PATCH 0/3] ib/ipoib: Enable IPoIB-UD 4K MTU support
Or Gerlitz
ogerlitz at voltaire.com
Wed Jan 30 23:27:19 PST 2008
Shirley Ma wrote:
> On Thu, 2008-01-31 at 09:04 +0200, Or Gerlitz wrote:
>> I see, but I want to make sure these patches are the one you want to
>> merge into the kernel or its more of a work in progress which you want
>> to be included in this experimental testbed called ofed.
> I will create patch for OFED-1.3-RC3 separately. I wouldn't call it's
> experimental code since these APIs have been tested along with IPoIB-CM
> already. They are pretty stable.
I meant to say that ofed is an experimental testbed, this is becoming
more and more clear to more and more people. I did not address your
patchset specifically.
>> If its candidate for upstream inclusion, I find it hard to review since
>> there is no per patch change-log.
> Thanks for the advice, I thought one change log was enough. If not, I
> will resubmit these patches along with one ling change-log.
If you think that for each of the patch one line change log is enough
for a reviewer, let it be, but if I were you, I would validate again
this assumption. The things is that when you send an RFC, many times
most of the documentation is in the virtual 0/N patch, but remember that
this documentation does not go into the git change-log, so in your
case since you want this to be merged, you have to work harder and
document both in the 0/N and also in the 1/N, 2/N ... N/N postings.
Or
More information about the general
mailing list