[ofa-general] Re: [PATCH 0/3] ib/ipoib: Enable IPoIB-UD 4K MTU support

Eli Cohen eli at mellanox.co.il
Thu Jan 31 01:28:23 PST 2008


Hi shirley,

my comments are:
1. The first patch (1/3) is malformed. I suggest you try to apply it
before sending.
2. Make sure they compile before submitting - patch 1/3 for example
changes ipoib_rx_buf

struct ipoib_rx_buf {
	struct sk_buff *skb;
	u64             mapping;
+       u64             mapping[IPOIB_CM_RX_SG];
 };

but does not change code in the UD flow to align with these changes.
3. Please put an explanation in the changelog.





More information about the general mailing list