[ofa-general] Re: [PATCH REPOST RFCv2 1/2] RDMA/Core: Add local dma lkey support.

[Steve Wise]

Steve Wise wrote:
> Or Gerlitz wrote:
>> Roland Dreier wrote:
>>>  > --- a/drivers/infiniband/hw/cxgb3/iwch_provider.c
>>>  > +    dev->ibdev.local_dma_lkey = 0;
>>>
>>> why this specific initialization but not in nes or amso1100?  I 
>>> think the device structure is zeroed out on allocation anyway.
>> To prevent confusion, lets have it documented somewhere that in the 
>> iwarp case IB_DEVICE_LOCAL_DMA_LKEY refers to zero-stag and as the 
>> name suggest its an lkey which equals zero, how does this sound?
>>
>
> I don't see the benefit.  Folks can read the RDMA Consortium verbs if 
> they want to understand about 0 stag.
>
> Steve.
>
I can add a comment in the code above if you think that's necessary.  
Something like:

/*
 * Use stag 0 for the global local access lkey.
 */