[ofa-general] Re: [PATCH v4 for-2.6.27] IPOIB: add LRO support.

[Roland Dreier]

 > I the past, few times you have commented that as far as its possible
 > to go without mod params, this should be the practice... for example
 > here sysfs entries set by various hotplug mechanisms, or telling the
 > user to upgrade their ethtool package, etc could serve to eliminate
 > the need in mod params.

 > During the review I asked why the default value for max_aggr is 64 and
 > it was ignored, also what we want the default value for use_lro to be?
 > I recall there was once a comment from Dave Miller saying why it would
 > be wise to have it off by default, I will look for that.

Yes, in general I prefer not to have module parameters, especially those
that duplicate functionality available through other mechanisms.
However, having lro and max_aggr parameters seems to match existing
practice for ethernet drivers, and 64 seems to be the common default for
max_aggr.

 - R.