[ofa-general] [PATCH] IB/IPoIB: Fix change mtu when switching to UD mode
Eli Cohen
eli at dev.mellanox.co.il
Wed Jul 2 23:41:34 PDT 2008
On Wed, Jul 02, 2008 at 10:33:41AM +0300, Or Gerlitz wrote:
> Eli Cohen wrote:
>> The fact that I did not hit such an assert does not mean I may avoid
>> taking the rtnl lock but it appears to me that the issue is not well
>> undrestood.
> Yes, linux networking internals are not easy to get... I suggest that you
> send netdev an email with more concrete subject - eg "required rtnl locking
> for netdev event notifiers..." which has larger chance to catch the eye of
> the maintainers.
>
So after getting some (two) answers and looking searching "rtnl lock",
I guess the correct way to go is to add rtnl lock/unlock. But I
conclude that we have to extend the usage of this lock farther to wrap
the modofications of the net device flags done, e.g. when changing
modes. If will create two patches then. One which adds rtnl locking
where necessary, and another one which uses dev_set_mtu() where
needed.
>
More information about the general
mailing list