[ofa-general] [PATCH for-2.6.27] RDMA/cxgb3 READ WR local_inv field uninitialized for normal reads.

Steve Wise swise at opengridcomputing.com
Thu Jul 3 14:59:02 PDT 2008


From: Steve Wise <swise at opengridcomputing.com>

Roland, you can merge this into the cxgb3 MEM_MGT_EXTENSIONS commit
if you want.

Steve.
---

RDMA/cxgb3 READ WR local_inv field uninitialized for normal reads.

Bug introduced by my read-with-inv changes.  Need to
set the local_inv field either way.

Signed-off-by: Steve Wise <swise at opengridcomputing.com>
---

 drivers/infiniband/hw/cxgb3/iwch_qp.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb3/iwch_qp.c b/drivers/infiniband/hw/cxgb3/iwch_qp.c
index 0526a6c..87ac970 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_qp.c
+++ b/drivers/infiniband/hw/cxgb3/iwch_qp.c
@@ -131,6 +131,8 @@ static int build_rdma_read(union t3_wr *wqe, struct ib_send_wr *wr,
 	wqe->read.rdmaop = T3_READ_REQ;
 	if (wr->opcode == IB_WR_RDMA_READ_WITH_INV)
 		wqe->read.local_inv = 1;
+	else
+		wqe->read.local_inv = 0;
 	wqe->read.reserved[0] = 0;
 	wqe->read.reserved[1] = 0;
 	wqe->read.rem_stag = cpu_to_be32(wr->wr.rdma.rkey);



More information about the general mailing list