[ofa-general] Re: [PATCH RFC] rds: add iwarp support

[Or Gerlitz]

Olaf Kirch wrote:
> Yes, that much I understand. For that reason, the rds_ib_device has two new flags: is_iwarp (local end point is iwarp device), and use_fastreg (device supports the fastreg interface, so create a mr_pool that uses fastreg instead of fmrs)
OK, got it. I am not sure why you need the "is_iwarp" flag, guess I have 
to look deeper into the patch you have posted or maybe you can comment 
on that here...
> Indeed, choice #1 isn't supported. The patch I posted will pick fastreg whenever
> the device advertises it. I would have preferred to do it the other way round,
> because the fmr code is pretty well tested by now. 
sounds fine for this point of time.
> Yes. credit management is there in 1.4, and on by default.
cool.
>
> I have to say I have no clue what other differences between ib and iwarp may be relevant. I can't think of any, but that's probably just my lack of imagination.
I suggest to use the optimistic set of mind for this and learn as we 
move forward.
>> The 5% difference are things supported by iWARP but not by IB such read-with-invalidate, etc
> Yeah. Let's get it working first, then
sure.

Or.